cta-observatory / cta-lstchain

LST prototype testbench chain
https://cta-observatory.github.io/cta-lstchain/
BSD 3-Clause "New" or "Revised" License
24 stars 77 forks source link

Make run_summary script work with ctar1 data, store format string #1179

Closed maxnoe closed 10 months ago

maxnoe commented 10 months ago

Counters are not used in case of CTA R1 input, so just don't compute them.

We rely on the event_time_s, event_time_qns and the event_type reported by EVB for this.

morcuended commented 10 months ago

I don't know if it's intended but the dragon_reference_counter is still being filled in case of CTA R1 data

run_id,n_subruns,run_type,data_format,ucts_timestamp,run_start,dragon_reference_time,dragon_reference_module_id,dragon_reference_module_index,dragon_reference_counter,dragon_reference_source
15346,4,DRS4,ProtoR1.CameraEvent,1699555104225806289,1699555097000000000,1699555104225806289,0,0,3225806000,ucts
15349,3,DRS4,CTAR1.Event,-1,-1,-1,-1,-1,18446744073709551615,None
15350,2,DRS4,CTAR1.Event,-1,-1,-1,-1,-1,18446744073709551615,None

I think it is somehow not getting COUNTER_DEFAULTS but actually looking into the files for this time information (?)

maxnoe commented 10 months ago

I don't know if it's intended but the dragon_reference_counter is still being filled in case of CTA R1 data

The dtype of the dragon reference is uint64, the value filled is uint64.max

maxnoe commented 10 months ago

Tests passing with fixed ctapipe_io_lst

codecov[bot] commented 10 months ago

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (644e43b) 73.96% compared to head (068af50) 73.93%.

Files Patch % Lines
lstchain/scripts/lstchain_create_run_summary.py 63.41% 15 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1179 +/- ## ========================================== - Coverage 73.96% 73.93% -0.04% ========================================== Files 125 125 Lines 12784 12810 +26 ========================================== + Hits 9456 9471 +15 - Misses 3328 3339 +11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.