search

cta-observatory / cta-lstchain

LST prototype testbench chain
https://cta-observatory.github.io/cta-lstchain/
BSD 3-Clause "New" or "Revised" License
24 stars 77 forks source link

Add missing wild card in pedestal search function to allow looking for symlinks in glob #1185

Closed FrancaCassol closed 10 months ago

FrancaCassol commented 10 months ago

The problem is that without the wildcard rglob/glob from pathlib do not look for symlinks.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e82bd68) 74.39% compared to head (67506a4) 74.39%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1185 +/- ## ======================================= Coverage 74.39% 74.39% ======================================= Files 129 129 Lines 13195 13195 ======================================= Hits 9816 9816 Misses 3379 3379 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

FrancaCassol commented 10 months ago

This change makes the function coherent with all the others that use rglob, l would say to merge this and move all to symlink in an other PR (when I will have more time to work on it)

rlopezcoto commented 10 months ago

This change makes the function coherent with all the others that use rglob, l would say to merge this and move all to symlink in an other PR (when I will have more time to work on it)

I agree, thanks. I created an issue not to forget to update the rglob calls in the future