cta-observatory / cta-lstchain

LST prototype testbench chain
https://cta-observatory.github.io/cta-lstchain/
BSD 3-Clause "New" or "Revised" License
22 stars 77 forks source link

Likelihood reconstruction update #1200

Closed gabemery closed 3 months ago

gabemery commented 5 months ago

This pull request covers 4 small changes:

  1. Adds the extraction of the pedestal variance used in the likelihood function from interleaved events. This was already covered in https://github.com/cta-observatory/cta-lstchain/pull/1124 but not merged at the time. This is more stable than the current, event-wise extraction and allows to account for pixel differences. It is also needed for data after DVR.
  2. Clean up a test and log message from when the code needed to be pre-compiled
  3. Add support of source dependent analysis with the likelihood reconstruction
  4. Remove the 'weight' argument. It was tested during development but is not used anymore.

All of these changes were already tested extensively in a modified version of lstchain 0.9.8

I also checked that it run successfully up to the creation of DL2 files in the current version on small v0.10 (no DVR) datasets (without in depth check of the file content). The updated config file fails during training due to #1206

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 32.00000% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 72.81%. Comparing base (1d98657) to head (c241816).

Files Patch % Lines
lstchain/reco/reconstructor.py 32.00% 17 Missing :warning:
lstchain/reco/dl1_to_dl2.py 33.33% 6 Missing :warning:
lstchain/reco/r0_to_dl1.py 20.00% 4 Missing :warning:
lstchain/scripts/lstchain_dl1_to_dl2.py 33.33% 4 Missing :warning:
lstchain/reco/reconstructorCC.py 40.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1200 +/- ## ========================================== - Coverage 72.92% 72.81% -0.12% ========================================== Files 133 133 Lines 13885 13911 +26 ========================================== + Hits 10126 10129 +3 - Misses 3759 3782 +23 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.