search

cta-observatory / cta-lstchain

LST prototype testbench chain
https://cta-observatory.github.io/cta-lstchain/
BSD 3-Clause "New" or "Revised" License
22 stars 77 forks source link

Set minimum intensity by default to 50 p.e. in example DL3 and IRF configs #1208

Closed morcuended closed 5 months ago

morcuended commented 5 months ago

Also, I still find it confusing that these config files are not in lstchain/data, together with the rest of lstchain config files. Shouldn't they be placed in the same location?

Moreover, these example config files are not included in the package data in setup.py:

    package_data={
        'lstchain': [
            'data/*',
            'resources/*',
        ],
    },
codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (089891d) 74.22% compared to head (14b9d1b) 74.22%. Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1208 +/- ## ======================================= Coverage 74.22% 74.22% ======================================= Files 130 130 Lines 13279 13279 ======================================= Hits 9857 9857 Misses 3422 3422 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

chaimain commented 5 months ago

I believe we had paused attempts to make the software easily usable for non-expert analyzers, and so we continued with the analysis practices that we initiated as is. Not sure if it is too late to make dedicated changes before the start of the upcoming software school...