cta-observatory / cta-lstchain

LST prototype testbench chain
https://cta-observatory.github.io/cta-lstchain/
BSD 3-Clause "New" or "Revised" License
22 stars 77 forks source link

Small update source-dependent DL3 step #1211

Closed SeiyaNozaki closed 5 months ago

SeiyaNozaki commented 5 months ago

There are two small updates in this PR.

  1. Sort DL3 file based on event_id after stacking data frame for each assumed source position (on, off_180 etc), just not to confuse analyzers
  2. Use the same reco position (derived from the first event) for all events. The reconstructed position fields were filled with the assumed source positions (ON and OFF) for each event. ON and OFF positions were selected based on the camera frame with respect to the source position on the camera. So the assumed OFF positions in ICRS frame differed for each event in principle. But, sometimes not all OFF events are extracted for higher analysis (gammapy) mostly with pre-defined region cut (0.1 degrees, stored in the header) mostly because of the telescope tracking condition. This PR solves such issue. image
codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (cd5f92f) 74.22% compared to head (59bc269) 74.24%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1211 +/- ## ========================================== + Coverage 74.22% 74.24% +0.01% ========================================== Files 130 130 Lines 13279 13286 +7 ========================================== + Hits 9857 9864 +7 Misses 3422 3422 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.