cta-observatory / cta-lstchain

LST prototype testbench chain
https://cta-observatory.github.io/cta-lstchain/
BSD 3-Clause "New" or "Revised" License
22 stars 77 forks source link

Update notebooks pointlike IRF and DL3 creation examples #1219

Closed morcuended closed 5 months ago

morcuended commented 5 months ago

For the DL2 to IRF notebook, I've created a separate updated notebook focusing on the point-like IRF. For the moment I leave the old notebook that was also explaining the full-enclosure and background IRF creation (which needs to be updated as well, but there are no new DL2 MC files for using them at the moment).

review-notebook-app[bot] commented 5 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

rlopezcoto commented 5 months ago

I guess this is necessary for your demonstration, right?

morcuended commented 5 months ago

I guess this is necessary for your demonstration, right?

Yes, I will use them

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7c13ed0) 72.66% compared to head (da4cb5e) 72.66%. Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1219 +/- ## ======================================= Coverage 72.66% 72.66% ======================================= Files 132 132 Lines 13648 13648 ======================================= Hits 9917 9917 Misses 3731 3731 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rlopezcoto commented 5 months ago

@moralejo can you update the notebooks for the school?