cta-observatory / cta-lstchain

LST prototype testbench chain
https://cta-observatory.github.io/cta-lstchain/
BSD 3-Clause "New" or "Revised" License
22 stars 77 forks source link

Update dl1 to dl2 script (Less required memory and less required step) #1224

Closed SeiyaNozaki closed 4 months ago

SeiyaNozaki commented 4 months ago

This PR updates the dl1 to dl2 step:

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 93.75000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 72.87%. Comparing base (1713092) to head (24ecab8). Report is 65 commits behind head on main.

Files Patch % Lines
lstchain/scripts/lstchain_dl1_to_dl2.py 88.88% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1224 +/- ## ========================================== + Coverage 72.67% 72.87% +0.19% ========================================== Files 132 133 +1 Lines 13655 13825 +170 ========================================== + Hits 9924 10075 +151 - Misses 3731 3750 +19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

SeiyaNozaki commented 4 months ago

Concerning the first point, it was on purpose for multiple input files... https://github.com/cta-observatory/cta-lstchain/pull/985

So I will modify codes like

SeiyaNozaki commented 4 months ago

I realized I didn't read carefully comments from @gabemery during the school... sorry!