Closed SeiyaNozaki closed 4 months ago
Attention: Patch coverage is 93.75000%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 72.87%. Comparing base (
1713092
) to head (24ecab8
). Report is 65 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
lstchain/scripts/lstchain_dl1_to_dl2.py | 88.88% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Concerning the first point, it was on purpose for multiple input files... https://github.com/cta-observatory/cta-lstchain/pull/985
So I will modify codes like
I realized I didn't read carefully comments from @gabemery during the school... sorry!
This PR updates the dl1 to dl2 step:
apply_models
. This option was already implemented inapply_models
, but not used for the script before.gammaness
andreco_type
. Butreco_type
can be set based ongammaness
as suggested by @maxnoe here. Even, we can removereco_type
which will not be used for the analysis. https://github.com/cta-observatory/cta-lstchain/pull/1077#discussion_r1104715136