cta-observatory / cta-lstchain

LST prototype testbench chain
https://cta-observatory.github.io/cta-lstchain/
BSD 3-Clause "New" or "Revised" License
24 stars 77 forks source link

Fake ERRORs in DL2 to DL3 step #1225

Closed moralejo closed 3 months ago

moralejo commented 7 months ago

When running the DL2 to DL3 step for a source-independent analysis, one gets this error if IRF interpolation is used:

2024-02-10 13:32:49,219 ERROR [lstchain.high_level.interpolate] (interpolate.interpolate_irf): AL CUTS not present for IRF interpolation Obviously, Alpha cuts do not exist for this type of analysis, and the DL3 file is nevertheless produced (as it should). If one uses explicitly the option --source-dep False

it is even worse... it throws the same error plus this one: 2024-02-10 13:28:32,031 ERROR [lstchain.DataReductionFITSWriter] (tool.run): Caught unexpected exception: File does not contain source-dependent parameters

The more you tell it you are doing a source-independent analysis, the more it wants to do it!

SeiyaNozaki commented 7 months ago

Yes... this is a fake error as reported also in #1180 and vice versa... (The script raises an error saying RAD_MAX is not present for IRF creation when using source-dependent analysis). Need to be fixed.

moralejo commented 7 months ago

Ok, I see. The same happens with the creation of the index files. It complains, for a point-like DL3 set, that the background and psf HDUs are missing...

2024-02-10 16:51:54,442 ERROR [lstchain.high_level.hdu_table] (hdu_table.create_hdu_index_hdu): Run 10946 does not contain HDU BACKGROUND 2024-02-10 16:51:54,442 ERROR [lstchain.high_level.hdu_table] (hdu_table.create_hdu_index_hdu): Run 10946 does not contain HDU PSF

SeiyaNozaki commented 7 months ago

Yes... I'm on it to solve this fake error