cta-observatory / cta-lstchain

LST prototype testbench chain
https://cta-observatory.github.io/cta-lstchain/
BSD 3-Clause "New" or "Revised" License
22 stars 77 forks source link

Fixed bug & couple of improvements in lstchain_dvr_pixselector #1237

Closed moralejo closed 4 months ago

moralejo commented 4 months ago

Fixed long-standing BUG which made that the info in the DVR_settings file produced by the script contained only the information of the last subrun.

Improvements in logging

Now by default only 10 files (subruns) of the input set, distributed uniformly along the run, are actually processed to determine the DVR settings. This is to speed up the process (since the settings are determined for the whole run, we do not need to check all subruns).

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 64.61538% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 72.86%. Comparing base (ea23f6e) to head (e6da544).

Files Patch % Lines
lstchain/scripts/lstchain_dvr_pixselector.py 64.61% 23 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1237 +/- ## ========================================== - Coverage 72.87% 72.86% -0.01% ========================================== Files 133 133 Lines 13797 13819 +22 ========================================== + Hits 10054 10069 +15 - Misses 3743 3750 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.