search

cta-observatory / cta-lstchain

LST prototype testbench chain
https://cta-observatory.github.io/cta-lstchain/
BSD 3-Clause "New" or "Revised" License
24 stars 77 forks source link

Compute cleaning thresholds in lstchain_dvr_pixselector #1239

Closed moralejo closed 7 months ago

moralejo commented 7 months ago

When used for determining the settings for the Data Volume Reduction (DVR) of a given run, the program now outputs also a .json file (adapted to the NSB conditions) for use in the lstchain_dl1ab step

moralejo commented 7 months ago

Also corrected a small error in earlier changes: in case more than one run was processed (in the "compute_dvr_settings" mode) the total number of (DL1) subruns processed was 10, instead of 10 per run, as intended.

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 85.41667% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 72.93%. Comparing base (a453522) to head (68d0475). Report is 6 commits behind head on main.

Files Patch % Lines
lstchain/scripts/lstchain_dvr_pixselector.py 85.41% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1239 +/- ## ========================================== + Coverage 72.86% 72.93% +0.07% ========================================== Files 133 133 Lines 13819 13864 +45 ========================================== + Hits 10069 10112 +43 - Misses 3750 3752 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.