cta-observatory / cta-lstchain

LST prototype testbench chain
https://cta-observatory.github.io/cta-lstchain/
BSD 3-Clause "New" or "Revised" License
22 stars 77 forks source link

Require ctapipe_io_lst 0.23, add evb preprocessing to run summary #1240

Closed maxnoe closed 4 months ago

maxnoe commented 4 months ago

This updates to ctapipe_io_lst, which includes the parsing of the EVB preprocessing steps.

This is also stored into the runsummary.

To not completely dominate the run summary with the string representation, I put the integer value and only for MONO events.

Here is how you can get something more human readable from that:

In [1]: from ctapipe_io_lst.evb_preprocessing import EVBPreprocessingFlag

In [2]: EVBPreprocessingFlag(103)
Out[2]: <EVBPreprocessingFlag.GAIN_SELECTION|BASELINE_SUBTRACTION|DELTA_T_CORRECTION|PEDESTAL_SUBTRACTION|PE_CALIBRATION: 103>

In [3]: EVBPreprocessingFlag(3)
Out[3]: <EVBPreprocessingFlag.GAIN_SELECTION|BASELINE_SUBTRACTION: 3>

In [4]: EVBPreprocessingFlag(2)
Out[4]: <EVBPreprocessingFlag.BASELINE_SUBTRACTION: 2>
morcuended commented 4 months ago

latest ctapipe io lst in condaforge is 0.22.6, that's why tests are failing (in the mamba setup)

moralejo commented 4 months ago

latest ctapipe io lst in condaforge is 0.22.6, that's why tests are failing (in the mamba setup)

It is there now, yet it keeps failing with the same error...

moralejo commented 4 months ago

Now it works

rlopezcoto commented 4 months ago

the pedestal file in the test is giving some trouble, probably related to the new implementation of the ctapipe_io_lst reading

maxnoe commented 4 months ago

Should be fixed now

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 56.00000% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 72.86%. Comparing base (fdb1a65) to head (2c562d7).

Files Patch % Lines
lstchain/scripts/lstchain_create_run_summary.py 56.52% 10 Missing :warning:
...tchain/tools/lstchain_create_drs4_pedestal_file.py 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1240 +/- ## ========================================== - Coverage 72.87% 72.86% -0.02% ========================================== Files 133 133 Lines 13825 13845 +20 ========================================== + Hits 10075 10088 +13 - Misses 3750 3757 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rlopezcoto commented 4 months ago

Great, thanks!