search

cta-observatory / cta-lstchain

LST prototype testbench chain
https://cta-observatory.github.io/cta-lstchain/
BSD 3-Clause "New" or "Revised" License
24 stars 77 forks source link

Update LST1 location from ctapipe_io_lst #1247

Closed chaimain closed 6 months ago

chaimain commented 6 months ago

Fixes #1220 and follows GADF convention in Header names.

Replaces the LST1 location information from ctapipe_io_lst.constants https://github.com/cta-observatory/ctapipe_io_lst/blob/main/src/ctapipe_io_lst/constants.py#L27-L35

review-notebook-app[bot] commented 6 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 76.19048% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 72.82%. Comparing base (133bf50) to head (e9bbb42).

Files Patch % Lines
lstchain/datachecks/containers.py 33.33% 2 Missing :warning:
lstchain/scripts/lstchain_dl2_add_sourcepos.py 50.00% 2 Missing :warning:
lstchain/reco/utils.py 83.33% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1247 +/- ## ======================================= Coverage 72.81% 72.82% ======================================= Files 133 133 Lines 13911 13915 +4 ======================================= + Hits 10129 10133 +4 Misses 3782 3782 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.