Closed vuillaut closed 1 month ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
pkg_resources is deprecated in favor of importlib.resources
Attention: Patch coverage is 96.00000%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 73.13%. Comparing base (
53dff7e
) to head (8cb517a
). Report is 1 commits behind head on main.:exclamation: Current head 8cb517a differs from pull request most recent head 57a41d5
Please upload reports for the commit 57a41d5 to get more accurate results.
Files | Patch % | Lines |
---|---|---|
lstchain/visualization/bokeh.py | 50.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for the review @morcuended Sorry I made a last-minute change to make sure the default file is indeed used in the tests. Could you review again please?
This PR fixes #1253 by: