cta-observatory / cta-lstchain

LST prototype testbench chain
https://cta-observatory.github.io/cta-lstchain/
BSD 3-Clause "New" or "Revised" License
22 stars 77 forks source link

fix missing SinglePhE_ResponseInPhE_expo2Gaus.dat #1254

Closed vuillaut closed 1 month ago

vuillaut commented 1 month ago

This PR fixes #1253 by:

review-notebook-app[bot] commented 1 month ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

morcuended commented 1 month ago

pkg_resources is deprecated in favor of importlib.resources

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 96.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 73.13%. Comparing base (53dff7e) to head (8cb517a). Report is 1 commits behind head on main.

:exclamation: Current head 8cb517a differs from pull request most recent head 57a41d5

Please upload reports for the commit 57a41d5 to get more accurate results.

Files Patch % Lines
lstchain/visualization/bokeh.py 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1254 +/- ## ========================================== + Coverage 73.11% 73.13% +0.02% ========================================== Files 134 134 Lines 14058 14058 ========================================== + Hits 10278 10282 +4 + Misses 3780 3776 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vuillaut commented 1 month ago

Thanks for the review @morcuended Sorry I made a last-minute change to make sure the default file is indeed used in the tests. Could you review again please?