Update of post_DL3_analysis notebook

cta-observatory / cta-lstchain

LST prototype testbench chain

https://cta-observatory.github.io/cta-lstchain/

BSD 3-Clause "New" or "Revised" License

22 stars 77 forks source link

Update of post_DL3_analysis notebook #1262

Open moralejo opened 3 weeks ago

moralejo commented 3 weeks ago

A bit of clean-up. Made the Content Summary consistent with the actual contents. Changed excess vs. sqrt(t) to excess vs. t (which is what is meaningful for a steady flux). Moved all the light curve calculations after the SED ones. It is not needed to re-do everything just to change the light curve energy range.

review-notebook-app[bot] commented 3 weeks ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.05%. Comparing base (e097079) to head (3e27215).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1262 +/- ## ======================================= Coverage 73.05% 73.05% ======================================= Files 134 134 Lines 14039 14039 ======================================= Hits 10256 10256 Misses 3783 3783 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

moralejo commented 3 weeks ago

This has been tested with the 2024 LST analysis school Crab data under /fefs/aswg/workspace/analysis-school-2024/DL3/Crab_Dec_2023

morcuended commented 3 weeks ago

I'll implement the comments