search

cta-observatory / cta-lstchain

LST prototype testbench chain
https://cta-observatory.github.io/cta-lstchain/
BSD 3-Clause "New" or "Revised" License
26 stars 77 forks source link

Replace test file #1291

Closed maxnoe closed 5 days ago

maxnoe commented 2 months ago

New file is not yet on the data server, but will be there tomorrow

review-notebook-app[bot] commented 2 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

morcuended commented 1 month ago

@maxnoe is the new test file already in the data server?

maxnoe commented 1 month ago

No, not yet. @kosack had some issues connecting to the server, but I think they are solved now.

But he's on vacation until the 4th

morcuended commented 4 weeks ago

@maxnoe, @kosack, a friendly reminder for the replacement of the test file.

maxnoe commented 2 weeks ago

Test file is now there, let's see

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.52%. Comparing base (cfd9a7f) to head (c025849). Report is 34 commits behind head on main.

Files with missing lines Patch % Lines
lstchain/reco/r0_to_dl1.py 0.00% 1 Missing :warning:
lstchain/scripts/lstchain_mc_r0_to_dl2.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1291 +/- ## ========================================== + Coverage 73.50% 73.52% +0.01% ========================================== Files 134 134 Lines 14211 14215 +4 ========================================== + Hits 10446 10451 +5 + Misses 3765 3764 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

morcuended commented 2 weeks ago

Maybe add a test for r0 to dl1 script running without input argument to make sure it works in the future.

morcuended commented 1 week ago

Added a test to check that running the script without input argument also works. I think this is good to go.