Write only images table (DL1a) if cleaning levels are set to 0

cta-observatory / cta-lstchain

LST prototype testbench chain

https://cta-observatory.github.io/cta-lstchain/

BSD 3-Clause "New" or "Revised" License

23 stars 77 forks source link

Write only images table (DL1a) if cleaning levels are set to 0 #246

Closed morcuended closed 4 years ago

morcuended commented 4 years ago

Related to #237

Provided cleaning levels are set to 0 in order to keep all the events, it does not make sense to calculate Hillas parameters. Thus DL1 output file should contain only images and pulse times tables in these cases.

vuillaut commented 4 years ago

Part of https://github.com/cta-observatory/cta-lstchain/projects/1#card-30110590

Once this refactoring is done, DL1a and b will be done in different steps and thus the event selection by cleaning will be done after DL1a . Although I was inclined to wait a bit to see things settling in ctapipe concerning DL1 processing tools and DL1 format to start this.

morcuended commented 4 years ago

Thanks for the clarification @vuillaut. Then, for the time being, should we implement in the dl0_to_dl1.py script the possibility of not storing the parameters table? Or do we just wait for ctapipe? I thought we could add just a line before writing the table checking whether cleaning levels are 0 or not as we discussed in the past call.