cta-observatory / ctapipe

Low-level data processing pipeline software for CTAO or similar arrays of Imaging Atmospheric Cherenkov Telescopes
https://ctapipe.readthedocs.org
BSD 3-Clause "New" or "Revised" License
62 stars 266 forks source link

Standardised outputs for event reconstruction #131

Closed ParsonsRD closed 7 years ago

ParsonsRD commented 8 years ago

In pull request #129 I added a first pass at a reconstruction module. However, at some point we should try to come up with a standard-ish set outputs for such classes. I would guess this means coming creating some kind of "reconstructed shower" container that looks similar to that for the Hillas parameterisations.

At a first guess I would say this should hold the reconstructed sky coordinates of the shower (in Alt, Az?), the core position (in the ground system), estimated energy, and xmax. Probably the uncertainty on all these values should be included as this is available in some analyses.

kosack commented 8 years ago

Yes, that sounds like a good idea. And do include uncertainty - I think that's even in the requirements or specs somewhere (or at least was heavily discussed). We want all reconstruction methods to at least try to estimate an uncertainty.

This brings up a main point about data structures: what should we be using for things like parametersizations (Hillas, reconstructions, gamma-hadron parameters, etc)?

Some use cases/requirements:

ParsonsRD commented 8 years ago

I created a simple example here #132 using a named tuple, but this may not have enough functionality for what we ultimately want to do with this. For pros and cons of each I don't have a good feeling for what would be best to go with. Can we assign a few people to the conversation here who may have more of a feeling for this?

ParsonsRD commented 7 years ago

This is a first pass at the variable we may need in the shower objects. Comments welcome!

Common output format for reconstruction

Separate energy output

TarekHC commented 7 years ago

Following this discussion, we created the shower_reco branch, and a pull request (#202) with a first direction reconstruction container and algorithm base class.