ArrayDisplay has some redundant code

cta-observatory / ctapipe

Low-level data processing pipeline software for CTAO or similar arrays of Imaging Atmospheric Cherenkov Telescopes

https://ctapipe.readthedocs.org

BSD 3-Clause "New" or "Revised" License

63 stars 267 forks source link

ArrayDisplay has some redundant code #2278

Open kosack opened 1 year ago

kosack commented 1 year ago

Describe the bug Calling ArrayDisplay.set_vector_hillas() requires a dict of hillas parameter containers, but doesn't actually use them anywhere... Instead the CoreParametersContainer is the only thing actually used.

Also it is missing a lot of convenience functions related to coordinate transforms, like the ability to add points correctly similar to CameraDisplay.

To Reproduce inspection

kosack commented 1 year ago

I'll try to open a PR to clean up ArrayDisplay soon. If there are features you think are useful, list them here. TO start:

CameraDisplay as has an ax attribute, while in ArrayDisplay it is called axes → should make the same
Missing an overlay_points() function