search

cta-observatory / ctapipe

Low-level data processing pipeline software for CTAO or similar arrays of Imaging Atmospheric Cherenkov Telescopes
https://ctapipe.readthedocs.org
BSD 3-Clause "New" or "Revised" License
64 stars 268 forks source link

Rename GeometryReco to HillasGeometryReco #2293

Closed Tobychev closed 1 year ago

Tobychev commented 1 year ago

Fixes parts of #2291, specifically

the GeometryReconstructor base class is poorly named, as it is really specific to Hillas-parameter based methods that would be inappropriate for e.g. a deep-learning or model based geometry reconstruction, and it does not set property=ReconstructionProperty.geometry in any case. HillasGeometryReconstructor would be a be better name

HealthyPear commented 1 year ago

If GeometryReconstructor is a "Base class for algorithms predicting only the shower geometry", shouldn't HillasGeometryReconstructor be a child class of this implementation calling the HillasReconstructor?

Tobychev commented 1 year ago

Updated the docstring after @HealthyPear's comment