cta-observatory / ctapipe

Low-level data processing pipeline software for CTAO or similar arrays of Imaging Atmospheric Cherenkov Telescopes
https://ctapipe.readthedocs.org
BSD 3-Clause "New" or "Revised" License
64 stars 268 forks source link

Fix SoftwareTrigger for actual simtel files #2320

Closed maxnoe closed 1 year ago

maxnoe commented 1 year ago

Fixes #2321

Tobychev commented 1 year ago

I can't tell what was wrong, the linked issue helps somewhat, but even that doesn't actually say what the resulting error is so I've no idea if this PR will solve it :man_shrugging:

maxnoe commented 1 year ago

@Tobychev not sure how to improve that, since:

What else is needed?

maxnoe commented 1 year ago

If you want to make sure, run the new tests with the code on Main, they fail with the error described in the issue

maxnoe commented 1 year ago

@Tobychev I updated the issue description with the full error message.