Open clara-escanuela opened 1 year ago
I'd suggest making this a separate cleaning function, rather than modifying TailCuts (which has already been modified so many times that it hardly looks simple anymore). Since tailcuts is the default algorithm, it's best to keep it simple. Another possibility is to make this algorithm call the tailcuts function, rather than modify it. That might require a small modification, but better than adding a loop to tailcuts_clean where there wasn't one before.
You will also need to add a new ImageCleaner subclass.
Maybe also have a look at this part of the VolumeReducer, i think its quite similar. Maybe you can write a function used in both classes?
Maybe also have a look at this part of the VolumeReducer, i think its quite similar. Maybe you can write a function used in both classes?
That would make sense I think. Or can we somehow alter the "dilate" function so that it has the option to only dilate pixels above certain threshold?
I think it is better to just add it as an extra cleaning method, otherwise dilate would not be so general and more input parameters would be required
By the way, what is the reason for CI / docs to fail? The error message is not so clear to me and I am curious as this is also happening in my other PR
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
8d61c03
) 92.47% compared to head (0fa134b
) 92.49%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This would be my approach for Issue #2326