search

cta-observatory / ctapipe

Low-level data processing pipeline software for CTAO or similar arrays of Imaging Atmospheric Cherenkov Telescopes
https://ctapipe.readthedocs.org
BSD 3-Clause "New" or "Revised" License
64 stars 268 forks source link

Fix return value of NullDataVolumeReducer #2340

Closed maxnoe closed 1 year ago

maxnoe commented 1 year ago

The data volume reduction classes are supposed to return a boolean mask for each pixel.

The NullDataVolumeReducer returned a mask for each (pixel, sample), comparing unnecessarily to 0.

Now, just a all-True boolean mask with the correct shape is returned.

maxnoe commented 1 year ago

astropy 5.3 was just released and it changed the order in which units are output as VO format string (in a good way!), I adapted the test so it doesn't care about the order