search

cta-observatory / ctapipe

Low-level data processing pipeline software for CTAO or similar arrays of Imaging Atmospheric Cherenkov Telescopes
https://ctapipe.readthedocs.org
BSD 3-Clause "New" or "Revised" License
64 stars 268 forks source link

Remove SimulationConfigContainer.injection_height, add SimulatedShowercontainer.starting_grammage #2343

Closed maxnoe closed 1 year ago

maxnoe commented 1 year ago

Fixes #2335

kosack commented 1 year ago

Does this merit a bump to the data model? It's not a really required part of the data, so maybe not (I mean it doesn't break reading old files, and up to now we don't use this column anywhere). So my feeling would be no, or at least a minor version change rather than major.

It's not an issue for this PR, but we should consider bumping it before the next release if there are enough changes