search

cta-observatory / ctapipe

Low-level data processing pipeline software for CTAO or similar arrays of Imaging Atmospheric Cherenkov Telescopes
https://ctapipe.readthedocs.org
BSD 3-Clause "New" or "Revised" License
64 stars 268 forks source link

Add support for using toymodel in telescope frame #2349

Closed maxnoe closed 1 year ago

maxnoe commented 1 year ago

missing tests

maxnoe commented 1 year ago

Just because I had the script already from #2347

https://github.com/cta-observatory/ctapipe/assets/5488440/ad475013-53d6-4e23-a765-84db08397f69

kosack commented 1 year ago

Maybe we should just finish removing the CameraFrame versions of all of this... Then we only support TelescopeFrame, and you can transform into CameraFrame to see the result.

Tobychev commented 1 year ago

Hi @maxnoe can you explain what bits are actually about the new functionality? Most of this seems to be more style refactoring so I'm not sure what bit is where it is important to look closely...

maxnoe commented 1 year ago

Most of this seems to be more style refactoring so I'm not sure what bit is where it is important to look closely...

Actually, none of this is style refactoring, it's all directly related to support the two frames we can have image parameters in.

In the current main, we use u.quantity_input(x=u.m, ..) to make sure units are valid, however, image parameters can be in either CameraFrame which uses length units on the sensor or TelescopeFrame which uses angles on the sky (in degree).

The units checks prevented the toymodel to be used in the TelescopeFrame, now we support both.