Closed maxnoe closed 9 months ago
There are actually booleans defining whether or not the warnings for missing R1/DL0 should be emitted. And for some reason they are set to True if the Calibrator encountered an event without R1/DL0: https://github.com/cta-observatory/ctapipe/blob/b9b2a1a73bf1f8ca6875fd19a00a2acb9f71ded1/ctapipe/calib/camera/calibrator.py#L155-L165
Why would that make any sense? You don't warn when finding an event, but then make sure to emit the warning for the following events?
Why would that make any sense? You don't warn when finding an event, but then make sure to emit the warning for the following events?
It's the other way around. The name is misleading. It's only raising the warning for the first event and then not again.
Describe the bug
When running ctapipe-process on DL0 input, the
CameraCalibrator
throws a warning (python warning, not log message):However, this is the expected case for almost anything (after all, ctapipe really starts at DL0), there shouldn't be a warning for the expected case.