Closed maxnoe closed 5 months ago
kosack
commented
10 months ago Great! this can also be used eventually to fill in the event-wise monitoring info in the event loop as well not just in TableLoader.
And just to note, this eventually must also interpolate other mis-pointing parameters like camera-z-axis rotation and any other deformation that needs to be applied during the DL1 step. LST doesn't compute those yet I guess, but it's good not to forget they will be necessary eventually!
codecov[bot]
commented
9 months ago Attention: Patch coverage is 98.00000% with 4 lines in your changes are missing coverage. Please review.
Project coverage is 92.64%. Comparing base (
f8d1049) to head (0d55e6e).
| Files | Patch % | Lines |
|---|---|---|
| src/ctapipe/io/pointing.py | 96.36% | 2 Missing :warning: |
| src/ctapipe/reco/sklearn.py | 60.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
ctao-dpps-sonarqube[bot]
commented
5 months ago 
0 Bugs
0 Vulnerabilities
3 Code Smells
98.00% Coverage (92.10% Estimated after merge)
0.00% Duplicated Code (0.70% Estimated after merge)Project ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs
This adds the possibility to interpolate pointing information from a not yet used by ctapipe itself
/dl0/monitoring/telescope/pointing/<tel_id>group.This is critical for analysis of e.g. LST observations.
At the moment, I add this table to the DL1 files output by ctapipe-process with a custom script, but eventually we should also add APIs for the datawriter / ctapipe-process / event sources to read this from monitoring files and put it into the outputs.