search

cta-observatory / ctapipe

Low-level data processing pipeline software for CTAO or similar arrays of Imaging Atmospheric Cherenkov Telescopes
https://ctapipe.readthedocs.org
BSD 3-Clause "New" or "Revised" License
63 stars 267 forks source link

Prevent users from using ImageModifier cumulatively #2410

Open Hckjs opened 10 months ago

Hckjs commented 10 months ago

Currently, you can always reapply the ImageModifer to already modified images using the process tool. I think it would be useful to prevent users from doing so for easier reproducibility of the data.

kosack commented 10 months ago

I guess technically you have the provenance log for each time you ran, and new files are written as well, so the chain of what happened is recorded. There could be a use case to apply modifications more than once. Is the problem that somebody might do this by accident?

Hckjs commented 10 months ago

Is the problem that somebody might do this by accident?

yes, at least a warning might be useful here i think - but in addition i also couldn't think of any use case, where it wouldn't be a better practice to just apply the image modifications on the not already modified image. Having just one specific set of applied modification parameters makes it easier (for others) to reproduce and compare the modified data.

I mean of course you can reproduce it anyway with the provenance logs but i was thinking more of a better/easier practice.