search

cta-observatory / ctapipe

Low-level data processing pipeline software for CTAO or similar arrays of Imaging Atmospheric Cherenkov Telescopes
https://ctapipe.readthedocs.org
BSD 3-Clause "New" or "Revised" License
63 stars 267 forks source link

Stabilize muon intensity fit #2425

Open RuneDominik opened 10 months ago

RuneDominik commented 10 months ago

See #2415

The cause of this issue might be that the likelihood values grow quite large and thus minuit does not converge properly as the values leave the [0, 1]-range by several orders of magnitude.

@maxnoe suggested to divide the likelihood used by the dof to lower the value. The likelihood is constructed to asymptotically resemble a chi2 so this changes the approach to chi2 per dof which does not change the minimum.

This does, ofc., not make the test more robust in any way.

maxnoe commented 10 months ago

This does, ofc., not make the test more robust in any way.

If this fixes the numerical issue that was the root cause, why not?

maxnoe commented 10 months ago

Docs builds failure is fixed in main, please rebase