search

cta-observatory / ctapipe

Low-level data processing pipeline software for CTAO or similar arrays of Imaging Atmospheric Cherenkov Telescopes
https://ctapipe.readthedocs.org
BSD 3-Clause "New" or "Revised" License
63 stars 267 forks source link

Change definition of leakage_pixel_{1,2} #2432

Closed maxnoe closed 9 months ago

maxnoe commented 10 months ago

I didn't need to change a unit test, which means the current definition is not really tested...

maxnoe commented 9 months ago

Proper test for leakage using artificial, simple images and changelog entry added.

Please review.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a2b6072) 92.48% compared to head (b3dbbc9) 92.48%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2432 +/- ## ======================================= Coverage 92.48% 92.48% ======================================= Files 234 234 Lines 19831 19853 +22 ======================================= + Hits 18340 18362 +22 Misses 1491 1491 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.