search

cta-observatory / ctapipe

Low-level data processing pipeline software for CTAO or similar arrays of Imaging Atmospheric Cherenkov Telescopes
https://ctapipe.readthedocs.org
BSD 3-Clause "New" or "Revised" License
63 stars 267 forks source link

Flatfielding factor instead of absolute & relative factor for amplitude correction #2433

Open StFroese opened 10 months ago

StFroese commented 10 months ago

closes #1397

Hckjs commented 3 weeks ago

Was it on purpose to set this PR to draft again? @maxnoe

maxnoe commented 5 days ago

: even if you can combine them, you are losing important information that is needed for data quality monitoring as well as for better reconstruction techniques that do not use the flatfielding information but do use the absolute gains.

The change here and discussed in #1397 is not about the monitored quantities, it's about what is filled into the event so that it can be applied in the CameraCalibrator.

I argued that the event should only contain a single correction coefficient, that is computed from all the different monitoring inputs we have for that specific event.