search

cta-observatory / ctapipe

Low-level data processing pipeline software for CTAO or similar arrays of Imaging Atmospheric Cherenkov Telescopes
https://ctapipe.readthedocs.org
BSD 3-Clause "New" or "Revised" License
63 stars 267 forks source link

Change how DataWriter writes simulation pointing #2438

Closed maxnoe closed 9 months ago

maxnoe commented 10 months ago

Instead of writing the unique pointings with their timestamp, which has no physical meaning in case of simulations, we now write the first pointing per observation block into the "/configuration/telescope/pointing/tel_nnn" tables.

Fixes #1484 and #1562

codecov[bot] commented 9 months ago

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (a2b6072) 92.48% compared to head (89b84a4) 92.46%. Report is 11 commits behind head on main.

Files Patch % Lines
ctapipe/io/hdf5eventsource.py 86.20% 4 Missing :warning:
ctapipe/conftest.py 90.90% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2438 +/- ## ========================================== - Coverage 92.48% 92.46% -0.02% ========================================== Files 234 234 Lines 19831 19846 +15 ========================================== + Hits 18340 18350 +10 - Misses 1491 1496 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.