search

cta-observatory / ctapipe

Low-level data processing pipeline software for CTAO or similar arrays of Imaging Atmospheric Cherenkov Telescopes
https://ctapipe.readthedocs.org
BSD 3-Clause "New" or "Revised" License
63 stars 267 forks source link

Remove code using instrument module to read camera def #244

Closed kosack closed 7 years ago

kosack commented 7 years ago

The issue with segfaults in #226 is likely due to the opening of 2 simultaneous simtel files (which the underlying libhessio.so library does not support).

Any code that needs to read the camera defs should not use the instrument module until it is redesigned.

io.CameraGeometry should be sufficient, and it should only be constructed from the data in the EventContainer generated by hessio_event_source, not via pyhessio functions directly.

This is causing very unstable code, that fails randomly on macOS machines in particular, and occasionally on linux (due to different memory handling likely)

kosack commented 7 years ago

This particularly affects the test code in the calib module which must be re-written

tino-michael commented 7 years ago

are we sure that the dictionary in _npix_to_type is correct/complete? particularly for ASTRI cameras I found a rotation of −90° and not the given 0° the attached plots show the "error" on the tilt angle of the hillas parametrisation for my rotation (top) and no rotation (bottom)

alpha_vs_signal_-90degree alpha_vs_signal_0degree

kosack commented 7 years ago

No, I think the npix_to_type array was simply reverse-engineered duing the Prod-2 production, and almost certainly needs updating.