cta-observatory / ctapipe

Low-level data processing pipeline software for CTAO or similar arrays of Imaging Atmospheric Cherenkov Telescopes
https://ctapipe.readthedocs.org
BSD 3-Clause "New" or "Revised" License
63 stars 266 forks source link

Bump setuptools version #2445

Closed morcuended closed 8 months ago

morcuended commented 8 months ago

I got this error in CI

ERROR: setuptools==59.6.0 is used in combination with setuptools_scm>=8.x

Your build configuration is incomplete and previously worked by accident!
setuptools_scm requires setuptools>=61

current settings in pyproject.toml are:

requires = ["setuptools >= 40.6.0", "setuptools_scm[toml]>=3.4"]

Can we upgrade to more recent versions?

requires = ["setuptools>=64", "setuptools_scm>=8"]
maxnoe commented 8 months ago

Yes, should be no problem. Why remove the "toml" extra though? I think we still need it.

morcuended commented 8 months ago

Yes, should be no problem. Why remove the "toml" extra though? I think we still need it.

You're right, just copied the line from the docs without [toml]