Fix coverage report not being found by codecov

cta-observatory / ctapipe

Low-level data processing pipeline software for CTAO or similar arrays of Imaging Atmospheric Cherenkov Telescopes

https://ctapipe.readthedocs.org

BSD 3-Clause "New" or "Revised" License

63 stars 266 forks source link

Fix coverage report not being found by codecov #2458

Closed maxnoe closed 8 months ago

maxnoe commented 8 months ago

Since we run our tests in a temporary directory, codecov didn't find the coverage.xml.

Due to a stupid default of fail_ci_if_error, this was silently ignored and the CI was still green. We didn't notice the missing codecov reports.

This fixes it by specifying the absolute path for coverage.xml and to make sure this does not happen again, I also set fail_ci_if_error to true

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@195a942). Click here to learn what that means.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2458 +/- ## ======================================= Coverage ? 60.60% ======================================= Files ? 3 Lines ? 33 Branches ? 0 ======================================= Hits ? 20 Misses ? 13 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.