search

cta-observatory / ctapipe

Low-level data processing pipeline software for CTAO or similar arrays of Imaging Atmospheric Cherenkov Telescopes
https://ctapipe.readthedocs.org
BSD 3-Clause "New" or "Revised" License
63 stars 266 forks source link

Add configuration for using CTAO sonarqube to check code #2463

Closed maxnoe closed 4 months ago

maxnoe commented 8 months ago

Testing sonarqube with the src layout and not changing to a tmp dir

maxnoe commented 8 months ago

mmh, still no luck:

INFO: Parsing report '/github/workspace/coverage.xml'
ERROR: Cannot resolve the file path 'src/ctapipe/__init__.py' of the coverage report, the file does not exist in all 'source'.
ERROR: Cannot resolve 244 file paths, ignoring coverage measures for those files
codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.58%. Comparing base (163b543) to head (c3cb18b). Report is 11 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2463 +/- ## ========================================== + Coverage 92.53% 92.58% +0.05% ========================================== Files 235 232 -3 Lines 20063 20031 -32 ========================================== - Hits 18565 18546 -19 + Misses 1498 1485 -13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

maxnoe commented 8 months ago

I briefly activated also push builds on pull requests to get a full report on sonarqube, not just the Pull Request diff checks, works now:

https://sonar-cta-dpps.zeuthen.desy.de/dashboard?id=ctapipe_github_9404f0f6-9294-11ed-bf3b-07aa00bdfe94&branch=sonarqube_src

maxnoe commented 4 months ago

@kosack The direction github → Sonarqube works now. For the other direction we need to setup a Github app and configuration on the sonarqube server I think, but this is good to go