search

cta-observatory / ctapipe

Low-level data processing pipeline software for CTAO or similar arrays of Imaging Atmospheric Cherenkov Telescopes
https://ctapipe.readthedocs.org
BSD 3-Clause "New" or "Revised" License
63 stars 266 forks source link

Properly transform between camera and telescope frame in muon fitter #2464

Closed maxnoe closed 8 months ago

maxnoe commented 8 months ago

The muon code did some strange things to transform pixel coordinates from camera to telescope frame, probably from code before camera geometries could be transformed as a whole.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c05b493) 92.47% compared to head (31e1c1e) 92.46%. Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2464 +/- ## ========================================== - Coverage 92.47% 92.46% -0.01% ========================================== Files 234 234 Lines 19816 19811 -5 ========================================== - Hits 18325 18319 -6 - Misses 1491 1492 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

maxnoe commented 8 months ago

@RuneDominik Yes, good point! I oversaw this change before.