search

cta-observatory / ctapipe

Low-level data processing pipeline software for CTAO or similar arrays of Imaging Atmospheric Cherenkov Telescopes
https://ctapipe.readthedocs.org
BSD 3-Clause "New" or "Revised" License
64 stars 268 forks source link

Add missing cache=True to numba compilation #2477

Closed maxnoe closed 10 months ago

maxnoe commented 10 months ago

This shaved of a third of the import time (of course only of the second import) of ctapipe.io as reported by @GernotMaier here: #2476

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b175f69) 92.46% compared to head (61f4062) 92.46%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2477 +/- ## ======================================= Coverage 92.46% 92.46% ======================================= Files 234 234 Lines 19868 19868 ======================================= Hits 18370 18370 Misses 1498 1498 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

maxnoe commented 10 months ago

Unfortunately, most of the remaining time is spent on importing tables.leaf, about a second on my machine, so that's out of our direct control.