search

cta-observatory / ctapipe

Low-level data processing pipeline software for CTAO or similar arrays of Imaging Atmospheric Cherenkov Telescopes
https://ctapipe.readthedocs.org
BSD 3-Clause "New" or "Revised" License
64 stars 268 forks source link

Fix docstring of ImPACT predict method #2499

Closed HealthyPear closed 8 months ago

HealthyPear commented 8 months ago

Just a small fix I found while roaming around the code...

The name of the geometry container should beReconstructedGeometryContainer and not ReconstructedShowerContainer.

HealthyPear commented 8 months ago

The linting failing job is caused by the fact that I used the onine github.dev web-based editor.

I can of course squash a commit from my local installation to fix stuff like isort changes, but what if we use ruff with the --fix option? Applying formatting or basic linting fixes manually post-commit can be disruptive to the development workflow.

The documentation job is instead failing for a reason which I believe is not related to my changes...

Tobychev commented 8 months ago

Could you make the changes directly on #2305 ? That's the "active" ImPACT pr and it has probably already touched these names.

HealthyPear commented 8 months ago

Could you make the changes directly on #2305 ? That's the "active" ImPACT pr and it has probably already touched these names.

sure no problem

HealthyPear commented 8 months ago

Actually this is already fixed in that branch, I didn't see it

I am going to close this PR since it is useless now