telescope trigger time is calculation is wrong in SimTelArrayEventSource

cta-observatory / ctapipe

Low-level data processing pipeline software for CTAO or similar arrays of Imaging Atmospheric Cherenkov Telescopes

https://ctapipe.readthedocs.org

BSD 3-Clause "New" or "Revised" License

62 stars 266 forks source link

Closed maxnoe closed 4 months ago

maxnoe commented 4 months ago

Describe the bug

From a discussion with Konrad, I checked again, and the way we currently compute the telescope trigger time:

central trigger time + relative_trigger_time

is wrong.

The telescope trigger time is relative to its start of readout (readout_time) not to the central trigger.

maxnoe commented 4 months ago

False alarm... we do use the correct trigger_times from the central trigger struct, not this relative_trigger_time