search

cta-observatory / ctapipe

Low-level data processing pipeline software for CTAO or similar arrays of Imaging Atmospheric Cherenkov Telescopes
https://ctapipe.readthedocs.org
BSD 3-Clause "New" or "Revised" License
64 stars 268 forks source link

Drop python 3.9 #2526

Closed maxnoe closed 6 months ago

maxnoe commented 6 months ago

The drop schedule according to NEP 29 says to drop 3.9 in the first week of April and the newer SPEC https://scientific-python.org/specs/spec-0000/ already dropped it.

So I think we should follow and for 0.21, also drop 3.9.

I used ruff --select=UP to check what can be changed and opted for now not converting every .format to an f-string and also didn't remove explicit encoding='utf-8' arguments as "explicit is better than implicit":

ruff --select=UP --ignore=UP032,UP012
ctao-dpps-sonarqube[bot] commented 6 months ago

Failed

Analysis Details

4 Issues

Coverage and Duplications

Project ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs

View in SonarQube

maxnoe commented 6 months ago

Checking the uncovered lines, it is all error conditions which we cannot really check in the tests reasonably.

I deactivated the hard "wait=True" which makes the whole CI fail in case of sonarqube not being happy.

ctao-dpps-sonarqube[bot] commented 6 months ago

Failed

Analysis Details

0 Issues

Coverage and Duplications

Project ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs

View in SonarQube

ctao-dpps-sonarqube[bot] commented 6 months ago

Failed

Analysis Details

0 Issues

Coverage and Duplications

Project ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs

View in SonarQube

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 81.42857% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 92.59%. Comparing base (01f4a99) to head (a61035d).

Files Patch % Lines
src/ctapipe/instrument/subarray.py 75.00% 3 Missing :warning:
src/ctapipe/tools/dump_instrument.py 0.00% 3 Missing :warning:
src/ctapipe/reco/sklearn.py 60.00% 2 Missing :warning:
src/ctapipe/instrument/camera/geometry.py 0.00% 1 Missing :warning:
src/ctapipe/instrument/camera/readout.py 0.00% 1 Missing :warning:
src/ctapipe/io/astropy_helpers.py 50.00% 1 Missing :warning:
src/ctapipe/io/metadata.py 0.00% 1 Missing :warning:
src/ctapipe/io/simteleventsource.py 83.33% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2526 +/- ## ======================================= Coverage 92.59% 92.59% ======================================= Files 233 232 -1 Lines 20056 20034 -22 ======================================= - Hits 18571 18551 -20 + Misses 1485 1483 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ctao-dpps-sonarqube[bot] commented 6 months ago

Passed

Analysis Details

0 Issues

Coverage and Duplications

Project ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs

View in SonarQube

ctao-dpps-sonarqube[bot] commented 6 months ago

Passed

Analysis Details

0 Issues

Coverage and Duplications

Project ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs

View in SonarQube

ctao-dpps-sonarqube[bot] commented 6 months ago

Passed

Analysis Details

0 Issues

Coverage and Duplications

Project ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs

View in SonarQube

ctao-dpps-sonarqube[bot] commented 6 months ago

Passed

Analysis Details

0 Issues

Coverage and Duplications

Project ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs

View in SonarQube