cta-observatory / ctapipe

Low-level data processing pipeline software for CTAO or similar arrays of Imaging Atmospheric Cherenkov Telescopes
https://ctapipe.readthedocs.org
BSD 3-Clause "New" or "Revised" License
64 stars 268 forks source link

Fix possible out of bounds error in FlashCamExtractor #2544

Closed maxnoe closed 5 months ago

maxnoe commented 5 months ago

The code had a possible out of bounds array access in case of the peak not being fully contained in the waveform.

Should fix a segfault reported by @gschwefer

maxnoe commented 5 months ago

macos test is now failing because macos-latest was updated to be macos 14 on M1 for which no pytables wheel exist, let's merge: #2534

ctao-dpps-sonarqube[bot] commented 5 months ago

Passed

Analysis Details

0 Issues

Coverage and Duplications

Project ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs

View in SonarQube

ctao-dpps-sonarqube[bot] commented 5 months ago

Passed

Analysis Details

0 Issues

Coverage and Duplications

Project ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs

View in SonarQube