search

cta-observatory / ctapipe

Low-level data processing pipeline software for CTAO or similar arrays of Imaging Atmospheric Cherenkov Telescopes
https://ctapipe.readthedocs.org
BSD 3-Clause "New" or "Revised" License
63 stars 267 forks source link

tailcuts_cleaning takes CameraGeomtry, hillas_parameters takes `pos_x`, `pos_y` #497

Closed maxnoe closed 6 years ago

maxnoe commented 7 years ago

I think this should be consistent

kosack commented 7 years ago

I think the reason was just that you can use the hillas algorithm for non-camera images as well (or at least cases where you haven't constructed a full CameraGeometry), but we could make it accept either.

kosack commented 7 years ago

A possibility is to also define a class like CherenkovImage that contains the image data + CameraGeometry and use that in all places where images are processed. Though sometimes the "image" is really a "movie" if there is a time axis, and may also have multiple gain channels, etc (I never could think of a good term).