search

cta-observatory / ctapipe

Low-level data processing pipeline software for CTAO or similar arrays of Imaging Atmospheric Cherenkov Telescopes
https://ctapipe.readthedocs.org
BSD 3-Clause "New" or "Revised" License
63 stars 267 forks source link

Add support for masks back into hillas parameters #572

Closed maxnoe closed 6 years ago

maxnoe commented 6 years ago

After the change to the hillas parameters API, it's no longer possible to use a cleaning mask.

I think this should be added again, possibly by adding a pixel_mask kwarg.

kosack commented 6 years ago

There is already masking support in CameraGeometry.

masked_geom = geom[mask]

hillas_parameters(masked_geom, masked_pixels)
kosack commented 6 years ago

we could as you suggest add an option, but then the function starts to get much more complicated.