This is just a reminder to look into why slicing is now causing a large overhead in calculating hillas params (it's probably something simple). Note that in this case, the mask and therefore sliced data only contains about 10 pixels, while the camera has several 1000. So normally, looping over the masked image would be much faster, and not 2x slower. It's likely due to some overhead introduced when the CameraGeometry is sliced. In the old implementation , we did not pass the CameraGeometry directly, only the pix_x and pix_y vectors, so the slicing was simpler.
This is just a reminder to look into why slicing is now causing a large overhead in calculating hillas params (it's probably something simple). Note that in this case, the mask and therefore sliced data only contains about 10 pixels, while the camera has several 1000. So normally, looping over the masked image would be much faster, and not 2x slower. It's likely due to some overhead introduced when the
CameraGeometry
is sliced. In the old implementation , we did not pass the CameraGeometry directly, only the pix_x and pix_y vectors, so the slicing was simpler.