search

cta-observatory / ctapipe_io_nectarcam

ctapipe plugin for reading nectarcam files
BSD 3-Clause "New" or "Revised" License
2 stars 11 forks source link

Update README.md #30

Closed mdpunch closed 1 year ago

mdpunch commented 1 year ago

Give a hint on installation (link to nectarchain page).

codecov[bot] commented 1 year ago

Codecov Report

Base: 96.03% // Head: 86.86% // Decreases project coverage by -9.17% :warning:

Coverage data is based on head (6ce3b60) compared to base (c92f4b6). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #30 +/- ## ========================================== - Coverage 96.03% 86.86% -9.18% ========================================== Files 8 9 +1 Lines 227 571 +344 ========================================== + Hits 218 496 +278 - Misses 9 75 +66 ``` | [Impacted Files](https://codecov.io/gh/cta-observatory/ctapipe_io_nectarcam/pull/30?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory) | Coverage Δ | | |---|---|---| | [ctapipe\_io\_nectarcam/calibration.py](https://codecov.io/gh/cta-observatory/ctapipe_io_nectarcam/pull/30/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory#diff-Y3RhcGlwZV9pb19uZWN0YXJjYW0vY2FsaWJyYXRpb24ucHk=) | `100.00% <0.00%> (ø)` | | | [ctapipe\_io\_nectarcam/\_\_init\_\_.py](https://codecov.io/gh/cta-observatory/ctapipe_io_nectarcam/pull/30/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory#diff-Y3RhcGlwZV9pb19uZWN0YXJjYW0vX19pbml0X18ucHk=) | `80.75% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

jlenain commented 1 year ago

Hi @mdpunch , Following the discussion on Slack, I am actually working towards a new installation procedure for both ctapipe_io_nectarcam and nectarchain, which would be consistent with the last changes in setuptools introduced by https://peps.python.org/pep-0660/, following @maxnoe 's path on ctapipe_io_lst. I would thus propose to wait a bit so that I could finish this and submit a PR, which will also make ctapipe_io_nectarcam properly pip-installable from the environment.yml provided in nectarchain.

jlenain commented 1 year ago

See #33 and the corresponding PR #32 .

jlenain commented 1 year ago

Superseeded by PR #32