search

cta-observatory / ctapipe_io_nectarcam

ctapipe plugin for reading nectarcam files
BSD 3-Clause "New" or "Revised" License
2 stars 11 forks source link

Add BlockNectarCAMEventSource class #60

Open vmarandon opened 1 month ago

vmarandon commented 1 month ago

Will read the data per block instead of all the files together. This remove the limitation of long acquisition that consume too much memory and reach quickly the limit of opened file.

The grouping of the blocks is 4 by default and correspond to the number of data stream of the acquisition.

There is also option to only read a certain set of blocks

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 13.82114% with 106 lines in your changes missing coverage. Please review.

Project coverage is 78.46%. Comparing base (60533fe) to head (85a98a5). Report is 40 commits behind head on main.

Files with missing lines Patch % Lines
src/ctapipe_io_nectarcam/__init__.py 13.82% 106 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #60 +/- ## =========================================== - Coverage 88.75% 78.46% -10.29% =========================================== Files 7 7 Lines 685 915 +230 =========================================== + Hits 608 718 +110 - Misses 77 197 +120 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jlenain commented 4 weeks ago

Hi @vmarandon !

Thanks a lot for that!

It would be good indeed if the new class BlockNectarCAMEventSource could inherit from NectarCAMEventSource.