cta-observatory / ctaplot

Plotting library for CTA and other IACT
https://ctaplot.readthedocs.io
MIT License
5 stars 9 forks source link

use seaborn-v0_8 as style, seaborn being deprecated #201

Closed vuillaut closed 12 months ago

codecov[bot] commented 12 months ago

Codecov Report

Patch coverage: 31.81% and project coverage change: +0.04% :tada:

Comparison is base (eafbe37) 63.15% compared to head (220df87) 63.20%. Report is 36 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #201 +/- ## ========================================== + Coverage 63.15% 63.20% +0.04% ========================================== Files 21 21 Lines 2717 2734 +17 ========================================== + Hits 1716 1728 +12 - Misses 1001 1006 +5 ``` | [Files Changed](https://app.codecov.io/gh/cta-observatory/ctaplot/pull/201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory) | Coverage Δ | | |---|---|---| | [ctaplot/gammaboard/reader.py](https://app.codecov.io/gh/cta-observatory/ctaplot/pull/201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory#diff-Y3RhcGxvdC9nYW1tYWJvYXJkL3JlYWRlci5weQ==) | `0.00% <0.00%> (ø)` | | | [ctaplot/gammaboard/gammaboard.py](https://app.codecov.io/gh/cta-observatory/ctaplot/pull/201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory#diff-Y3RhcGxvdC9nYW1tYWJvYXJkL2dhbW1hYm9hcmQucHk=) | `11.81% <2.94%> (-0.10%)` | :arrow_down: | | [ctaplot/ana/ana.py](https://app.codecov.io/gh/cta-observatory/ctaplot/pull/201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory#diff-Y3RhcGxvdC9hbmEvYW5hLnB5) | `88.20% <86.66%> (-0.03%)` | :arrow_down: | | [ctaplot/\_\_init\_\_.py](https://app.codecov.io/gh/cta-observatory/ctaplot/pull/201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory#diff-Y3RhcGxvdC9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | | | [ctaplot/ana/tests/test\_ana.py](https://app.codecov.io/gh/cta-observatory/ctaplot/pull/201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory#diff-Y3RhcGxvdC9hbmEvdGVzdHMvdGVzdF9hbmEucHk=) | `100.00% <100.00%> (ø)` | | | [ctaplot/plots/plots.py](https://app.codecov.io/gh/cta-observatory/ctaplot/pull/201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory#diff-Y3RhcGxvdC9wbG90cy9wbG90cy5weQ==) | `78.49% <100.00%> (+0.02%)` | :arrow_up: | | [ctaplot/plots/style.py](https://app.codecov.io/gh/cta-observatory/ctaplot/pull/201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory#diff-Y3RhcGxvdC9wbG90cy9zdHlsZS5weQ==) | `100.00% <100.00%> (ø)` | | | [ctaplot/plots/tests/test\_plots.py](https://app.codecov.io/gh/cta-observatory/ctaplot/pull/201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory#diff-Y3RhcGxvdC9wbG90cy90ZXN0cy90ZXN0X3Bsb3RzLnB5) | `98.73% <100.00%> (+0.07%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

maxnoe commented 12 months ago
examples/notebooks/roc_curves.ipynb
160:    "    reco_proba[p] = np.ones_like(mc_type, dtype=np.float)\n",

notebook fails to render due to numpy removing these aliases a couple of versions ago

review-notebook-app[bot] commented 12 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

morcuended commented 12 months ago

docs deployment problem might come from the new sphinx v7 being incompatible with rtd_theme (?). So maybe force sphinx < 7 EDIT: or use the new sphinx_rtd_theme version that apparently supports sphinx 7

maxnoe commented 12 months ago

Locally building worked with sphinx 7 and rtd theme, let's see

vuillaut commented 12 months ago

the build on rtd still uses sphinx 7 🤔