search

cta-observatory / eventio_kaitai

Prototyping a Katai struct implementation of eventio data structures
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

Test eventio.ksy #1

Closed zonca closed 1 year ago

zonca commented 1 year ago

just to familiarize myself with the tools, I've ported most of the test_open_file.py unit test from pyeventio to the Kaitai version and used Github Actions to run it.

zonca commented 1 year ago

Github action is running fine on my repository: https://github.com/zonca/eventio_kaitai/actions/runs/6788645920/job/18454092780

maxnoe commented 1 year ago

@zonca I added you as developer to this repository, so in principle you don't need to fork.

zonca commented 1 year ago

@maxnoe thanks, I added that function as a standalone function. it would probably be nice to make it a method of Object, if I understand how to do it. I think this PR is ready to merge unless you have feedback

zonca commented 1 year ago

@maxnoe thanks for the feedback.

I wanted to do this small improvement over the current status of the repository and do a Python package for the next step, see #4. So I wouldn't bother with issues related to packaging and to the makefile right now. However, if you prefer to have first a Python package, I can close this pull request and do another one when I have a full python package properly implemented.

maxnoe commented 1 year ago

I don't mind the order, if this already helps, let's go

zonca commented 1 year ago

thanks @maxnoe, yes, I prefer to do smaller pull requests that gradually improve I saved the important comment about lazy loading in #7. Can you approve and merge this PR?

zonca commented 1 year ago

@maxnoe ok done