cta-observatory / iact_event_types

BSD 3-Clause "New" or "Revised" License
4 stars 7 forks source link

Implementing full-enclosure IRFs #41

Closed TarekHC closed 1 year ago

TarekHC commented 2 years ago

After discussion between Orel, Victor, Juan and Tarek, we came up with the following recipe:

TarekHC commented 2 years ago

We checked current pyirf code, and it seems effective area and energy migration is already being computed for the following cuts:

masks = {
    "": gammas["selected"],
    "_NO_CUTS": slice(None),
    "_ONLY_GH": gammas["selected_gh"],
    "_ONLY_THETA": gammas["selected_theta"],
}

To test if these full-enclosure effective areas are consistent with the ones computed within ED, we could:

  1. Compare ED point-like vs full-enclosure effective area.
  2. Compute standard effective area with OnSource gammas with pyirf.
  3. Compute _ONLY_GH effective area with a 1-deg gamma-cone file with pyirf.
  4. Compare these two, and see if the difference is roughly consistent with ED.
TarekHC commented 2 years ago

Some of the modifications needed at the pyirf stage (either within pyirf, or scripts we need to develop on our side) are being discussed here and here.

JBernete commented 1 year ago

I think we can close this issue. Event-type-wise full-enclosure IRFs have already been tested with Gammapy.