search

cta-observatory / lst-sim-config

Repository to store configurations of MC simulations for LST (+MAGIC)
0 stars 1 forks source link

Fix magic mirror degradation #35

Closed jsitarek closed 2 years ago

jsitarek commented 2 years ago

this is not used for MAGIC simulation, but it is used for LST1, so if LST1 and MAGIC are simulated together it needs to be reset not to propagate the LST1 number it should solve issue #34

sorry for the typo in the branch name it should be fix_...

maxnoe commented 2 years ago

I am not sure about how the single telescope configurations work exactly, but I see in array.cfg that for TELESCOPE==0, the LST1.cfg is included with the comment "global settings".

Wouldn't it make more sense to not include the LST1 config for TELESCOPE==0 so that LST settings do not interfer with MAGIC settings?

Not entirely sure if that would be the effect.

jsitarek commented 2 years ago

Hi @maxnoe,

I made a quick test and this in principle would work, but it causes other problems. If you do not load LST1 file, when the old HESS defaults are loaded they are all interpreted before reading all the individual telescope settings. This means also the transmission files, pulse shapes etc stored in the files, and not all of those files are available in cfg/hess. So we would need either dummy files there, or write a small default.cfg file, that just sets the settings that are missing to reasonable values.

jsitarek commented 2 years ago

no matter if in the end we got for a solution to avoid using the LST1 defaults, I think it is either way a good idea to have all the relevant settings explicitely specified in the input card, @Voutsi, since there is still a pending review from your side please let me know if we can merge this one. In the meantime I'm preparing next PR with other (more minor settings) that were inheired from LST, and possibly tuning them a bit for MAGIC

maxnoe commented 2 years ago

@jsitarek Yes, but when we add the next option for LST or change the value away from the common default, we have to remember to change the option back in MAGIC{1,2}.cfg, which is not ideal.

I think it would be much better to have a common_defaults.cfg included for TELESCOPE==0 instead of the LST1 config.

jsitarek commented 2 years ago

I agree @maxnoe, we can make another PR with it. Nevertheless then we would also need to make sure that the same common_defaults are used when a major CTA productions are done.